Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Design Tokens & Add New Text Variants #19853

Merged
merged 7 commits into from
Jun 30, 2023
Merged

Update Design Tokens & Add New Text Variants #19853

merged 7 commits into from
Jun 30, 2023

Conversation

garrettbear
Copy link
Contributor

@garrettbear garrettbear commented Jun 30, 2023 •
edited
Loading

Explanation

  • Update design-token package to latest version
  • Add new Text variants from the design-token update

Screenshots/Screencaps

Before

Screenshot 2023-06-30 at 9 55 10 AM

After

Screenshot 2023-06-30 at 9 54 28 AM

Manual Testing Steps

Compare new Text variants to design-token variants

LocalHost vs Design Tokens

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@garrettbear garrettbear marked this pull request as ready for review June 30, 2023 17:24
@garrettbear garrettbear requested a review from a team as a code owner June 30, 2023 17:24
garrettbear
garrettbear commented Jun 30, 2023
View reviewed changes
ui/components/component-library/button-base/button-base.js
@@ -65,7 +65,7 @@ export const ButtonBase = ({
className,
)}
disabled={disabled}
display={DISPLAY.INLINE_FLEX}
display={Display.InlineFlex}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was originally going to update ButtonBase textVariant, but doing it in a different PR since it changes so many files
#19852

still updating the const in this PR.

NidhiKJha
NidhiKJha previously approved these changes Jun 30, 2023
View reviewed changes
darkwing
darkwing previously approved these changes Jun 30, 2023
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [b5f7e78]
Page Load Metrics (1601 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1061821362411
domContentLoaded14081863160112359
load14081863160112359
domInteractive14081863160112359

@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #19853 (65f4ac0) into develop (6bb5e69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #19853   +/-   ##
========================================
  Coverage    69.70%   69.70%           
========================================
  Files          982      982           
  Lines        37071    37071           
  Branches      9944     9944           
========================================
  Hits         25840    25840           
  Misses       11231    11231
Impacted Files Coverage Δ
...nents/component-library/button-base/button-base.js 100.00% <ø> (ø)
ui/components/component-library/text/text.types.ts 100.00% <ø> (ø)
ui/helpers/constants/design-system.ts 100.00% <ø> (ø)

georgewrmarshall
georgewrmarshall requested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Need to update example code in README

Screenshot 2023-06-30 at 10 47 04 AM

@georgewrmarshall
Copy link
Contributor

Colors readme could use an update too
Screenshot 2023-06-30 at 10 50 42 AM

@garrettbear garrettbear dismissed stale reviews from darkwing and NidhiKJha via 65f4ac0 June 30, 2023 18:03
georgewrmarshall
georgewrmarshall approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@metamaskbot
Copy link
Collaborator

Builds ready [65f4ac0]
Page Load Metrics (1643 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1103131444421
domContentLoaded15041860164210048
load15041860164310048
domInteractive15031860164210048

@garrettbear garrettbear merged commit a41219c into develop Jun 30, 2023
9 checks passed
@garrettbear garrettbear deleted the feat/19590/update-button-font-weight-medium branch June 30, 2023 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@vthomas13 vthomas13 Awaiting requested review from vthomas13

@NidhiKJha NidhiKJha Awaiting requested review from NidhiKJha

Assignees
No one assigned
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update design-tokens and add new body medium
5 participants
@garrettbear @metamaskbot @georgewrmarshall @darkwing @NidhiKJha