Fix hold to reveal button on mobile browsers #19847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
requested review from
HowardBraham,
garrettbear and
montelaidev
Comment on lines
-6
to
+7
| import Box from '../../ui/box'; | ||
| import { | ||
| AlignItems, | ||
| DISPLAY, | ||
| Display, |
There was a problem hiding this comment.
Replacing deprecated code
Comment on lines
199
to
200
| onPointerDown={onMouseDown} | ||
| onPointerUp={onMouseUp} |
There was a problem hiding this comment.
"integrates various inputs from mice, touchscreens, and pens, making separate implementations no longer necessary and authoring for cross-device pointers easier. Not to be mistaken with the unrelated "pointer-events" CSS property." https://caniuse.com/pointer
georgewrmarshall
force-pushed
the
fix/hold-to-reveal-mobile-browsers
branch
from
305ac8e
to
57936bf
Compare
georgewrmarshall
force-pushed
the
fix/hold-to-reveal-mobile-browsers
branch
from
8c7ece0
to
c92919b
Compare
Builds ready [81d2271]
Page Load Metrics (1587 ± 34 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19847 +/- ##
========================================
Coverage 69.68% 69.68%
========================================
Files 982 982
Lines 37067 37067
Branches 9941 9941
========================================
Hits 25829 25829
Misses 11238 11238
|
|
LGTM and worked on iPhone RPReplay_Final1688152375.MP4 |
garrettbear
approved these changes
Jun 30, 2023
HowardBraham
approved these changes
Jun 30, 2023
metamaskbot
added
the
release-10.35.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently users who use the extension on their mobile devices are not able to reveal their SRP because the hold to reveal button is not working. This PR changes the
onMouseDownandonMouseUpevents toonPointerDownandonPointerUpwhich "integrates various inputs from mice, touchscreens, and pens, making separate implementations no longer necessary and authoring for cross-device pointers easier."https://caniuse.com/pointer
Screenshots/Screencaps
Before
Checking the story of the
HoldToRevealButtonon an iPhone doesn't workhold.to.reveal.button.mp4
After
Checking story of the
HoldToRevealButtonon iPhoneRPReplay_Final1688150899.MP4
Still working in extension in Chrome browsers
hold.to.reveal.desktop.after.mov
Manual Testing Steps
HoldToRevealButtonPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.