Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Added custom title for institutional #19844

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

albertolive
Copy link
Contributor

Explanation

In the window title and in the “Connect with …“ message.

image

AC:

The correct naming, “Metamask Institutional,” has been applied.

A PR has been created for the team to review

Ticket:
https://consensyssoftware.atlassian.net/browse/MMI-3325

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue

@albertolive albertolive requested a review from a team as a code owner June 30, 2023 13:03
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -4,6 +4,9 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta charset="utf-8">
<title>MetaMask Notification</title>
{{@if(it.isMMI)}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oh i didn't know about this syntax. Glad it works !!

DDDDDanica
DDDDDanica previously approved these changes Jun 30, 2023
@albertolive albertolive merged commit 7c7b5fe into develop Jun 30, 2023
9 checks passed
@albertolive albertolive deleted the feature/MMI-3325-notification-window branch June 30, 2023 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
@metamaskbot metamaskbot added the release-10.34.0 Issue or pull request that will be included in release 10.34.0 label Jun 30, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [165845c]
Page Load Metrics (1642 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1032201422512
domContentLoaded14521885164212359
load14521885164212359
domInteractive14521885164212359
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants