Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Added code fence to remove backup notice #19840

Conversation

albertolive
Copy link
Contributor

Explanation

In the institutional build, we don't want to show the backup notice because the keys are stored in the custodian.

image

AC:

  • The backup message does not popup anymore

Ticket:
https://consensyssoftware.atlassian.net/browse/MMI-3342

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue

@albertolive albertolive requested a review from a team as a code owner June 30, 2023 10:44
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [731f2f8]
Page Load Metrics (1473 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint10513911695
domContentLoaded1372161514736833
load1373161514736833
domInteractive1372161514736833

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #19840 (731f2f8) into develop (6bb5e69) will not change coverage.
The diff coverage is 12.50%.

@@           Coverage Diff            @@
##           develop   #19840   +/-   ##
========================================
  Coverage    69.70%   69.70%           
========================================
  Files          982      982           
  Lines        37071    37071           
  Branches      9944     9944           
========================================
  Hits         25840    25840           
  Misses       11231    11231           
Impacted Files Coverage Δ
ui/pages/home/home.component.js 44.39% <12.50%> (ø)

@albertolive albertolive merged commit 5545e5e into develop Jun 30, 2023
9 checks passed
@albertolive albertolive deleted the feature/MMI-3342-remove-the-backup-recovery-phrase-message branch June 30, 2023 12:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
@metamaskbot metamaskbot added the release-10.34.0 Issue or pull request that will be included in release 10.34.0 label Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants