Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing deprecated constants & creating stories #19686

Merged

Conversation

dhruvv173
Copy link
Contributor

@dhruvv173 dhruvv173 commented Jun 20, 2023

Explanation

ui/components/institutional/compliance-details
ui/components/multichain/product-tour-popover

Also created stories for ConfirmGasDisplay and ConnectedAccountPermissions

  1. ui/components/app/confirm-gas-display
  2. ui/components/app/connected-accounts-permissions

Screenshots/Screencaps

ComplianceDetails

Before

image
image

After

image
image
image

ProductTourPopover

Before

image
image
image

After

image
image
image

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173 dhruvv173 marked this pull request as ready for review June 20, 2023 19:12
@dhruvv173 dhruvv173 requested a review from a team as a code owner June 20, 2023 19:12
@dhruvv173 dhruvv173 requested a review from adonesky1 June 20, 2023 19:12
@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension needs-ux-ds-review labels Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #19686 (32c362f) into develop (ed702af) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19686      +/-   ##
===========================================
- Coverage    70.79%   70.79%   -0.01%     
===========================================
  Files          988      988              
  Lines        38366    38366              
  Branches     10042    10042              
===========================================
- Hits         27161    27159       -2     
- Misses       11205    11207       +2     
Impacted Files Coverage Δ
...itutional/compliance-details/compliance-details.js 90.48% <ø> (ø)
...chain/product-tour-popover/product-tour-popover.js 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@georgewrmarshall georgewrmarshall merged commit 1c7c89a into MetaMask:develop Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
@dhruvv173 dhruvv173 deleted the issue/replace-deprecated-constants branch July 14, 2023 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants