Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating story for multilayer-fee-message & nft-options #19567

Merged
merged 5 commits into from
Jun 20, 2023

Conversation

rohiiittttt
Copy link
Contributor

@rohiiittttt rohiiittttt commented Jun 12, 2023

Explanation

  • created a story for multilayer fee message
  • created a story for Nft options

Screenshots/Screencaps

image
image
yarn jest
image

NFT options
image
image
yarn jest
image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@rohiiittttt rohiiittttt requested a review from a team as a code owner June 12, 2023 09:44
@rohiiittttt rohiiittttt requested a review from segun June 12, 2023 09:44
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@rohiiittttt rohiiittttt changed the title creating story for multilayer fee message creating story for multilayer-fee-message & nft-options Jun 12, 2023
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 12, 2023
@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for segun June 12, 2023 19:25
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution @rohiiittttt. Remember to use actions for function type props. Have updated. LGTM!

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #19567 (0fa090b) into develop (f77b1f6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19567      +/-   ##
===========================================
- Coverage    70.29%   70.28%   -0.01%     
===========================================
  Files          973      973              
  Lines        37250    37250              
  Branches      9603     9603              
===========================================
- Hits         26183    26181       -2     
- Misses       11067    11069       +2     

see 2 files with indirect coverage changes

@garrettbear garrettbear merged commit 4a8a4aa into MetaMask:develop Jun 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants