Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replacing deprecated constants with enums #19516

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

dhruvv173
Copy link
Contributor

Explanation

  • This PR is a part of Replace deprecated constants with enums #18714
  • Made changes to
  • ui/components/app/advanced-gas-fee-popover/advanced-gas-fee-defaults/advanced-gas-fee-defaults.js
  • ui/components/app/modals/contract-details-modal/contract-details-modal.js
  • ui/components/app/network-account-balance-header/network-account-balance-header.js

Screenshots/Screencaps

Before

Theres no story for advanced-gas-fee-defaults

contract-details-modal
image
image

network-account-balance-header
image
image

After

contract-details-modal
image
image

network-account-balance-header
image
image

Manual Testing Steps

  • Pull this branch
  • Run yarn storybook
  • Check stories for contract-details-modal and network-account-balance-header

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner June 8, 2023 14:22
@dhruvv173 dhruvv173 requested a review from jpuri June 8, 2023 14:22
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 8, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches! Please update with your suggestions and I can approve. Well done 💯

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #19516 (f96f3e5) into develop (8eff1fc) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19516      +/-   ##
===========================================
- Coverage    70.17%   70.16%   -0.01%     
===========================================
  Files          963      963              
  Lines        36980    36980              
  Branches      9510     9510              
===========================================
- Hits         25948    25946       -2     
- Misses       11032    11034       +2     
Impacted Files Coverage Δ
...nced-gas-fee-defaults/advanced-gas-fee-defaults.js 100.00% <ø> (ø)
...s/contract-details-modal/contract-details-modal.js 68.09% <ø> (ø)
...t-balance-header/network-account-balance-header.js 87.50% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @dhruvv173

@garrettbear garrettbear merged commit ab0374d into MetaMask:develop Jun 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
@dhruvv173 dhruvv173 deleted the issue/18714 branch July 18, 2023 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants