Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating story for icon-border #19467

Merged

Conversation

dhruvv173
Copy link
Contributor

Explanation

  • Created story for icon-border component

  • ui/components/ui/icon-border

Screenshots/Screencaps

Before

image

After

image

after.mp4

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner June 6, 2023 13:57
@dhruvv173 dhruvv173 requested a review from vinistevam June 6, 2023 13:57
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173
Copy link
Contributor Author

dhruvv173 commented Jun 6, 2023

hey @georgewrmarshall, Is it fine to open a PR for each component added to Storybook? I can include 2-3 components per PR if it makes it easier for you to review them.
Additionally, some of these folders do not have a test file, Can I create test files for those components?
Thanks for the considering this request, and please review this PR when possible.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #19467 (8138137) into develop (b5b3f67) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8138137 differs from pull request most recent head 87ddf33. Consider uploading reports for the commit 87ddf33 to get more accurate results

@@             Coverage Diff             @@
##           develop   #19467      +/-   ##
===========================================
- Coverage    69.99%   69.99%   -0.01%     
===========================================
  Files          960      960              
  Lines        36804    36804              
  Branches      9454     9454              
===========================================
- Hits         25760    25758       -2     
- Misses       11044    11046       +2     

see 2 files with indirect coverage changes

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 6, 2023
@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for vinistevam June 6, 2023 20:13
@georgewrmarshall
Copy link
Contributor

Hey @dhruvv173, one story per PR is good! If you would also like to contribute to our priority good first issue you could have a look at these:

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dhruvv173, I realized this is a deprecated component. I've updated with a deprecation message. If you'd like to help us with some tech debt reduction I've listed some issues above. Thanks again for your contribution

Screenshot 2023-06-07 at 3 11 18 PM

ui/components/ui/icon-border/icon-border.stories.js Outdated Show resolved Hide resolved
@garrettbear garrettbear merged commit 58f6cf9 into MetaMask:develop Jun 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
@dhruvv173 dhruvv173 deleted the feat/adding-story-icon-border branch July 18, 2023 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants