Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replacing deprecated constants in approve-content-card folder #19448

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

rohiiittttt
Copy link
Contributor

Explanation

Replaced deprecated design system and storybook constants in the approve-content-card folder
ui/components/app/approve-content-card

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@rohiiittttt rohiiittttt requested a review from a team as a code owner June 5, 2023 16:57
@rohiiittttt rohiiittttt requested a review from hmalik88 June 5, 2023 16:57
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 5, 2023
@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for hmalik88 June 5, 2023 17:41
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need tests to pass. I'll try remerging develop

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #19448 (ebeb76d) into develop (5355000) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #19448      +/-   ##
===========================================
- Coverage    69.98%   69.98%   -0.01%     
===========================================
  Files          959      959              
  Lines        36790    36790              
  Branches      9452     9452              
===========================================
- Hits         25747    25745       -2     
- Misses       11043    11045       +2     
Impacted Files Coverage Δ
...s/app/approve-content-card/approve-content-card.js 75.00% <50.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @rohiiittttt

@NidhiKJha NidhiKJha merged commit 15bdb32 into MetaMask:develop Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants