Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 17670 replace typography with text #19433

Conversation

ujwalkumar1995
Copy link
Contributor

Explanation

As part of this PR, I have replaced the usage of Typography with Text. The files are:

  • ui/components/ui/numeric-input/numeric-input.component.js
  • ui/components/app/signature-request/signature-request-message/signature-request-message.js
  • ui/components/app/signature-request/signature-request.component.js

Screenshots/Screencaps

Before

ui/components/ui/numeric-input/numeric-input.component.js:

Default:
Screenshot 2023-06-04 141849

With Detail:
Screenshot 2023-06-04 141911

With Error:
Screenshot 2023-06-04 141927

ui/components/app/signature-request/signature-request-message/signature-request-message.js:

Screenshot 2023-06-04 142000

ui/components/app/signature-request/signature-request.component.js:

Screenshot 2023-06-04 142151

After

ui/components/ui/numeric-input/numeric-input.component.js:

Default:
Screenshot 2023-06-04 141412

With Detail:
Screenshot 2023-06-04 141438

With Error:
Screenshot 2023-06-04 141519

ui/components/app/signature-request/signature-request-message/signature-request-message.js:

Screenshot 2023-06-04 141633

ui/components/app/signature-request/signature-request.component.js:

Screenshot 2023-06-04 141758

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@ujwalkumar1995 ujwalkumar1995 requested a review from a team as a code owner June 4, 2023 08:55
@ujwalkumar1995 ujwalkumar1995 requested a review from danjm June 4, 2023 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ujwalkumar1995
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for danjm June 5, 2023 15:23
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 5, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ujwalkumar1995, this is looking great! I've made some small updates while I had your brach checked out on my local. Thanks for your contribution!

@georgewrmarshall georgewrmarshall force-pushed the issue-17670-replace-typography-with-text branch from abf4bc7 to f5c9cd7 Compare June 6, 2023 03:15
@ujwalkumar1995
Copy link
Contributor Author

Thank you @georgewrmarshall for the feedback.
I will try to keep these things in mind while submitting future PRs.

garrettbear
garrettbear previously approved these changes Jun 6, 2023
Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall dismissed stale reviews from garrettbear and themself via 94461f9 June 19, 2023 18:09
@georgewrmarshall georgewrmarshall force-pushed the issue-17670-replace-typography-with-text branch from 94461f9 to e98dcd4 Compare June 19, 2023 18:23
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #19433 (0edc0ce) into develop (fc2402d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #19433      +/-   ##
===========================================
- Coverage    69.83%   69.82%   -0.01%     
===========================================
  Files          980      980              
  Lines        36886    36886              
  Branches      9890     9890              
===========================================
- Hits         25757    25755       -2     
- Misses       11129    11131       +2     
Impacted Files Coverage Δ
...t-original/signature-request-original.component.js 61.11% <ø> (ø)
...ature-request-message/signature-request-message.js 36.84% <ø> (ø)
...p/signature-request/signature-request.component.js 76.71% <ø> (ø)
...onents/ui/numeric-input/numeric-input.component.js 50.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgewrmarshall georgewrmarshall merged commit 04839a2 into MetaMask:develop Jun 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
3 participants