Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replace deprecated constants with enums in: AvatarBase and Text #19242

Merged

Conversation

dhruvv173
Copy link
Contributor

Explanation

All the deprecated constants were replaced with their equivalent enums.
Deprecated storybook tags were also replaced.

The changes were made in the component-library folder:
ui/components/component-library/avatar-base
ui/components/component-library/text

Screenshots/Screencaps

AvatarBase

Before

image
image
image
image

After

image
image
image
image

Text

Before

image
image
image
image
image
image
image
image
image
image
image
image

After

image
image
image
image
image
image
image
image
image
image
image
image

Manual Testing Steps

jest tests passed locally
image

image

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 20, 2023 20:13
@dhruvv173 dhruvv173 requested a review from bergarces May 20, 2023 20:13
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #19242 (69d4c91) into develop (9d38e53) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19242      +/-   ##
===========================================
- Coverage    70.30%   70.30%   -0.01%     
===========================================
  Files          960      960              
  Lines        36689    36689              
  Branches      9543     9543              
===========================================
- Hits         25793    25791       -2     
- Misses       10896    10898       +2     
Impacted Files Coverage Δ
...ents/component-library/avatar-base/avatar-base.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@dhruvv173
Copy link
Contributor Author

dhruvv173 commented May 20, 2023

Hey @georgewrmarshall , could you please review this PR when possible?
Thank you!

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 20, 2023
@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and removed request for bergarces May 20, 2023 21:06
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great PR description 👍 Thanks for your contribution @dhruvv173 🙏

@NidhiKJha NidhiKJha merged commit 61e952b into MetaMask:develop Jun 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
@dhruvv173 dhruvv173 deleted the Replacing-constants-with-enums branch July 25, 2023 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants