Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replacing typography consts with enums #19013

Merged

Conversation

dhruvv173
Copy link
Contributor

Explanation

This PR is a part of #18714
Replaced Typography consts with enums in the file ui/components/app/asset-list/asset-list.js

Screenshots/Screencaps

Before

WhatsApp Image 2023-05-04 at 22 17 00

After

WhatsApp Image 2023-05-04 at 22 17 21

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 4, 2023 16:57
@dhruvv173 dhruvv173 requested a review from hmalik88 May 4, 2023 16:57
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173
Copy link
Contributor Author

dhruvv173 commented May 4, 2023

hey @georgewrmarshall could you check this PR once, it fails the snaps test.
The yarn jest path/to/folder --updateSnapshot did not work, am I supposed to run any other command to update the changes?

Edit: It passed all the tests. @georgewrmarshall can I continue making changes to other files in the same way?
Thanks alot!

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just rerunning e2e tests. Thanks for your contribution 👍

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 5, 2023
@DDDDDanica DDDDDanica changed the title Replacing typography consts with enums Part of #18714: Replacing typography consts with enums May 5, 2023
@DDDDDanica DDDDDanica merged commit 69132e7 into MetaMask:develop May 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
@dhruvv173 dhruvv173 deleted the Replacing-Typography-consts-with-enums branch July 25, 2023 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants