Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #17670: Replace Typography with Text component in cancel-speedup-popover.js #18948

Merged
merged 4 commits into from
May 3, 2023

Conversation

dhruvv173
Copy link
Contributor

@dhruvv173 dhruvv173 commented May 2, 2023

Explanation

Partially fixes #17670
Made changes by replacing the Typography component with Text component in the cancel-speedup-popover.js file
ui/components/app/cancel-speedup-popover/cancel-speedup-popover.js

Couldnt attach the screenshot as the file wasnt found on storybook

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 2, 2023 13:03
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173 dhruvv173 changed the title Part of [#17670](https://github.com/MetaMask/metamask-extension/issues/17670): Replace Typography with Text component in cancel-speedup-popover.js Part of #17670: Replace Typography with Text component in cancel-speedup-popover.js May 2, 2023
@dhruvv173 dhruvv173 changed the title Part of #17670: Replace Typography with Text component in cancel-speedup-popover.js Part of (#17670)[https://github.com/MetaMask/metamask-extension/issues/17670]: Replace Typography with Text component in cancel-speedup-popover.js May 2, 2023
@dhruvv173 dhruvv173 changed the title Part of (#17670)[https://github.com/MetaMask/metamask-extension/issues/17670]: Replace Typography with Text component in cancel-speedup-popover.js Part of (#17670) [https://github.com/MetaMask/metamask-extension/issues/17670]: Replace Typography with Text component in cancel-speedup-popover.js May 2, 2023
@dhruvv173 dhruvv173 changed the title Part of (#17670) [https://github.com/MetaMask/metamask-extension/issues/17670]: Replace Typography with Text component in cancel-speedup-popover.js Part of #17670: Replace Typography with Text component in cancel-speedup-popover.js May 2, 2023
@dhruvv173
Copy link
Contributor Author

dhruvv173 commented May 2, 2023

hey @NidhiKJha I created a new PR for this fix, this passes all the tests, please review it when possible.
Thanks!

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution

@NidhiKJha NidhiKJha added the team-design-system All issues relating to design system in Extension label May 2, 2023
@DDDDDanica
Copy link
Contributor

Hey @dhruvv173 thanks for contributing, it looks good !
However, can you add the before/after screenshot as comparison to make sure we didn't change the styles as required in #17670?

Before / After screenshots of changes in PR description or as comments near relevant code

Thank you !

@DDDDDanica DDDDDanica added the DO-NOT-MERGE Pull requests that should not be merged label May 2, 2023
@dhruvv173
Copy link
Contributor Author

Hey @dhruvv173 thanks for contributing, it looks good ! However, can you add the before/after screenshot as comparison to make sure we didn't change the styles as required in #17670?

Before / After screenshots of changes in PR description or as comments near relevant code

Thank you !

hey @DDDDDanica I couldnt attach before/after screenshots as the story file does not exist on storybook

@DDDDDanica DDDDDanica removed the DO-NOT-MERGE Pull requests that should not be merged label May 3, 2023
@NidhiKJha NidhiKJha merged commit 28b3490 into MetaMask:develop May 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
4 participants