Update knobs to control: MetamaskTemplateRenderer #18677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
Comment on lines
-94
to
-109
| export const WithInvalidElement = () => ( | ||
| <MetaMaskTemplateRenderer | ||
| sections={object('sections', [ | ||
| { | ||
| ...SECTIONS, | ||
| key: 'safe-tree', | ||
| }, | ||
| { | ||
| element: 'Unsafe', | ||
| key: 'unsafe-tree', | ||
| children: | ||
| 'I should be displayed, but I wont be due to unsafe component', | ||
| }, | ||
| ])} | ||
| /> | ||
| ); |
There was a problem hiding this comment.
I suggested to @dj-pundir to remove this story as it was display an error intentionally but I don't think it adds much value in storybook
Done the linting. Thanks!! |
georgewrmarshall
approved these changes
Apr 22, 2023
georgewrmarshall
added
the
team-design-system
brad-decker
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The knobs are deprecated so its in continuity with other tasks to change the knobs with controls. Following are changes to the component
metamask-template-renderer.stories.jsWithInvalidElementstory altogetherFixes: #18498
Screenshots/Screencaps
Here is
Before
After
Manual Testing Steps
yarn storybookPre-merge author checklist
Pre-merge reviewer checklist