Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #17670: Replace Typography with Text component in RecoveryPhraseReminder #18639

Conversation

kremalicious
Copy link
Contributor

Part of #17670.

Switch Typography components with Text component within the RecoveryPhraseReminder . Additionally, created story for it. And switched some markup around so that all items in that popover use the Text component, so all line height and text treatment is now consistent among all items.

Screenshots/Screencaps

Before

Screenshot 2023-04-18 at 14 47 48

Screenshot 2023-04-18 at 14 47 54

After

Screenshot 2023-04-18 at 14 53 54

Screenshot 2023-04-18 at 14 53 58

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@kremalicious kremalicious requested a review from a team as a code owner April 18, 2023 13:57
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Apr 19, 2023
@brad-decker
Copy link
Contributor

Thanks for the contribution @kremalicious -- I'm updating your branch and seeing if we can get the build process passing, if it doesn't pass i'll investigate the issue and report here.

@DDDDDanica DDDDDanica merged commit f621092 into MetaMask:develop Apr 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2023
@kremalicious kremalicious deleted the feature/17670-recovery-phrase-reminder branch April 27, 2023 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants