Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated TextField component with TextField from the component-library #20483

Open
georgewrmarshall opened this issue Aug 16, 2023 · 4 comments
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Aug 16, 2023

Description

Currently, the extension is using an outdated TextField component, which needs to be replaced with the new TextField component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements. It also means that this issue will not be assigned to a single engineer

Technical Details

  • Replace instances of TextField component (ui/components/ui/text-field/text-field.component.js) with TextField component (ui/components/component-library/text-field/text-field.js)
  • Component APIs are slightly different so ensure all props have been migrated appropriately
  • Ensure there are no visual or functional regressions

Acceptance Criteria

  • Instances of TextField component are completely replaced with the new TextField component
  • The component APIs are updated to reflect the changes in the new `TextField`` component and there is no functional changes or visual regression
  • Each Pull Request (PR) should include no more than 3 files
  • The code changes should pass Jest tests, linting, and Storybook without any errors.
  • The PR must include before and after screenshots of the UI to ensure there are no visual regressions.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension good first issue Good for newcomers labels Aug 16, 2023
@ShatilKhan
Copy link

Hi @georgewrmarshall
I would like to take on this issue. I've recently done some contributions into components in meshery.io.
Can you please assign me this issue?

@subhajit20
Copy link
Contributor

@georgewrmarshall Made a PR.
Can you assign it to me?

@mohdshubair313
Copy link

Hey @georgewrmarshall can you assign this issue to me. I can work on this issue @georgewrmarshall

@besalraj30
Copy link

Hi

I’d like to work on this issue. Could you assign it to me? @georgewrmarshall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension
Projects
None yet
Development

No branches or pull requests

5 participants