Skip to content

Commit

Permalink
fix: "Update Network: should delete added rpc url for exis..." flaky …
Browse files Browse the repository at this point in the history
…test (#27350)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR addresses a flaky test issue caused by a popover dialog that
appears. The presence of this popover dialog prevents the test from
interacting with the intended element leading to test failures.

To resolve this, I have included the clickSafeElement method to safely
click the "Got it" button on the popover dialog.

![image](https://github.com/user-attachments/assets/250f99fb-9db4-46ae-a16f-7c86caac3ac0)

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27350?quickstart=1)

## **Related issues**

Fixes:
#27334

## **Manual testing steps**

Run the test using below commands locally or in codespaces:
yarn
yarn build:test:webpack
ENABLE_MV3=false yarn test:e2e:single
test/e2e/tests/network/update-network.spec.ts --browser=chrome

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
hjetpoluru authored Sep 24, 2024
1 parent ca9be28 commit a9b69a4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/e2e/tests/network/update-network.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ describe('Update Network:', function (this: Suite) {

// Re-open the network menu
await driver.delay(regularDelayMs);
await driver.clickElementSafe({ text: 'Got it', tag: 'h6' });
await driver.clickElement('[data-testid="network-display"]');

// Go back to edit the network
Expand Down

0 comments on commit a9b69a4

Please sign in to comment.