Skip to content

Commit

Permalink
fix: [cherry-pick][V12.5.0] account syncing bugfix (#27761)
Browse files Browse the repository at this point in the history
## **Description**

This PR bumps `@metamask/profile-sync-controller` to version `0.9.7`.
This version fixes an account sync bug where we would save imported
accounts in user storage.

This is a cherry pick for:
PR: #27749
Commit:
86525fd

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27761?quickstart=1)

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1215

## **Manual testing steps**

1. Create a new SRP
2. Add new accounts, rename some
3. Uninstall extension and reinstall
4. Import your previously created SRP
5. All your previously created accounts and respective names should be
there!

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
  • Loading branch information
mathieuartu and metamaskbot authored Oct 11, 2024
1 parent 073c9fe commit 0736532
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions lavamoat/browserify/beta/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -2036,6 +2036,7 @@
"Event": true,
"Headers": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"URLSearchParams": true,
"addEventListener": true,
Expand Down
1 change: 1 addition & 0 deletions lavamoat/browserify/flask/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -2036,6 +2036,7 @@
"Event": true,
"Headers": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"URLSearchParams": true,
"addEventListener": true,
Expand Down
1 change: 1 addition & 0 deletions lavamoat/browserify/main/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -2036,6 +2036,7 @@
"Event": true,
"Headers": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"URLSearchParams": true,
"addEventListener": true,
Expand Down
1 change: 1 addition & 0 deletions lavamoat/browserify/mmi/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -2128,6 +2128,7 @@
"Event": true,
"Headers": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"URLSearchParams": true,
"addEventListener": true,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@
"@metamask/post-message-stream": "^8.0.0",
"@metamask/ppom-validator": "0.34.0",
"@metamask/preinstalled-example-snap": "^0.1.0",
"@metamask/profile-sync-controller": "^0.9.4",
"@metamask/profile-sync-controller": "^0.9.7",
"@metamask/providers": "^14.0.2",
"@metamask/queued-request-controller": "^2.0.0",
"@metamask/rate-limit-controller": "^6.0.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6053,9 +6053,9 @@ __metadata:
languageName: node
linkType: hard

"@metamask/profile-sync-controller@npm:^0.9.4":
version: 0.9.4
resolution: "@metamask/profile-sync-controller@npm:0.9.4"
"@metamask/profile-sync-controller@npm:^0.9.7":
version: 0.9.7
resolution: "@metamask/profile-sync-controller@npm:0.9.7"
dependencies:
"@metamask/base-controller": "npm:^7.0.1"
"@metamask/keyring-api": "npm:^8.1.3"
Expand All @@ -6071,7 +6071,7 @@ __metadata:
"@metamask/accounts-controller": ^18.1.1
"@metamask/keyring-controller": ^17.2.0
"@metamask/snaps-controllers": ^9.7.0
checksum: 10/86079da552eed316f2754bd899047de1d8d9d15d390c9cdee0aef66b95bea708b5c7929a8d8d946210cc0e4c52347fee971a5cf5130149d0ca60abdc85f47774
checksum: 10/e53888533b2aae937bbe4e385dca2617c324b34e3e60af218cd98c26d514fb725f4c67b649f126e055f6a50a554817b229d37488115b98d70e8aee7b3a910bde
languageName: node
linkType: hard

Expand Down Expand Up @@ -26131,7 +26131,7 @@ __metadata:
"@metamask/post-message-stream": "npm:^8.0.0"
"@metamask/ppom-validator": "npm:0.34.0"
"@metamask/preinstalled-example-snap": "npm:^0.1.0"
"@metamask/profile-sync-controller": "npm:^0.9.4"
"@metamask/profile-sync-controller": "npm:^0.9.7"
"@metamask/providers": "npm:^14.0.2"
"@metamask/queued-request-controller": "npm:^2.0.0"
"@metamask/rate-limit-controller": "npm:^6.0.0"
Expand Down

0 comments on commit 0736532

Please sign in to comment.