WIP: Update after dependency updates

MetaMask · Sep 21, 2023 · e7d31c1 · e7d31c1
1 parent 6dc9d97
commit e7d31c1
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 21 deletions.
diff --git a/src/block-tracker-inspector.ts b/src/block-tracker-inspector.ts
@@ -1,6 +1,10 @@
 import type { JsonRpcMiddleware } from '@metamask/json-rpc-engine';
 import { createAsyncMiddleware } from '@metamask/json-rpc-engine';
-import type { JsonRpcParams, PendingJsonRpcResponse } from '@metamask/utils';
+import type {
+  Json,
+  JsonRpcParams,
+  PendingJsonRpcResponse,
+} from '@metamask/utils';
 import type { PollingBlockTracker } from 'eth-block-tracker';
 
 import { projectLogger, createModuleLogger } from './logging-utils';
@@ -35,7 +39,7 @@ function hasProperty<ObjectToCheck, Property extends ValidPropertyType>(
 }
 
 function getResultBlockNumber(
-  response: PendingJsonRpcResponse<JsonRpcParams>,
+  response: PendingJsonRpcResponse<Json>,
 ): string | undefined {
   const { result } = response;
   if (
@@ -57,7 +61,7 @@ export function createBlockTrackerInspectorMiddleware({
   blockTracker,
 }: BlockTrackerInspectorMiddlewareOptions): JsonRpcMiddleware<
   JsonRpcParams,
-  JsonRpcParams
+  Json
 > {
   return createAsyncMiddleware(async (req, res, next) => {
     if (!futureBlockRefRequests.includes(req.method)) {

diff --git a/src/retryOnEmpty.test.ts b/src/retryOnEmpty.test.ts
@@ -1,10 +1,8 @@
 import { providerFromEngine } from '@metamask/eth-json-rpc-provider';
 import type { SafeEventEmitterProvider } from '@metamask/eth-json-rpc-provider';
-import type {
-  JsonRpcMiddleware,
-  JsonRpcRequest,
-} from '@metamask/json-rpc-engine';
+import type { JsonRpcMiddleware } from '@metamask/json-rpc-engine';
 import { JsonRpcEngine } from '@metamask/json-rpc-engine';
+import type { Json, JsonRpcParams, JsonRpcRequest } from '@metamask/utils';
 import { PollingBlockTracker } from 'eth-block-tracker';
 
 import { createRetryOnEmptyMiddleware } from '.';
@@ -223,7 +221,11 @@ describe('createRetryOnEmptyMiddleware', () => {
 
               expect(await promiseForResponse).toMatchObject({
                 error: expect.objectContaining({
-                  message: 'RetryOnEmptyMiddleware - retries exhausted',
+                  data: expect.objectContaining({
+                    cause: expect.objectContaining({
+                      message: 'RetryOnEmptyMiddleware - retries exhausted',
+                    }),
+                  }),
                 }),
               });
             },
@@ -674,7 +676,9 @@ async function withTestSetup<T>(
  * @param requestStub - The request/response pair.
  * @returns The request/response pair, properly typed.
  */
-function stubGenericRequest<T, U>(requestStub: ProviderRequestStub<T, U>) {
+function stubGenericRequest<T extends JsonRpcParams, U extends Json>(
+  requestStub: ProviderRequestStub<T, U>,
+) {
   return requestStub;
 }
 
@@ -690,7 +694,10 @@ function stubGenericRequest<T, U>(requestStub: ProviderRequestStub<T, U>) {
  * return when called past `numberOfTimesToFail`.
  * @returns The request/response pair, properly typed.
  */
-function stubRequestThatFailsThenFinallySucceeds<T, U>({
+function stubRequestThatFailsThenFinallySucceeds<
+  T extends JsonRpcParams,
+  U extends Json,
+>({
   request,
   numberOfTimesToFail,
   successfulResponse,
@@ -745,7 +752,7 @@ async function waitForRequestToBeRetried({
   numberOfTimes,
 }: {
   sendAsyncSpy: jest.SpyInstance;
-  request: JsonRpcRequest<unknown>;
+  request: JsonRpcRequest;
   numberOfTimes: number;
 }) {
   let iterationNumber = 1;

diff --git a/src/wallet.ts b/src/wallet.ts
@@ -7,7 +7,6 @@ import {
 import { providerErrors, rpcErrors } from '@metamask/rpc-errors';
 import type {
   Json,
-  JsonRpcParams,
   JsonRpcRequest,
   PendingJsonRpcResponse,
 } from '@metamask/utils';

diff --git a/test/util/createHitTrackerMiddleware.ts b/test/util/createHitTrackerMiddleware.ts
@@ -1,17 +1,14 @@
-import type { JsonRpcMiddleware, JsonRpcRequest } from 'json-rpc-engine';
+import type { JsonRpcMiddleware } from '@metamask/json-rpc-engine';
+import type { Json, JsonRpcParams, JsonRpcRequest } from '@metamask/utils';
 
 interface CreateHitTrackerMiddleware {
-  getHits(method: string): JsonRpcRequest<any>[];
+  getHits(method: string): JsonRpcRequest[];
 }
 
 export default function createHitTrackerMiddleware() {
-  const hitTracker: Record<string, JsonRpcRequest<any>[]> = {};
-  const middleware: JsonRpcMiddleware<any, any> & CreateHitTrackerMiddleware = (
-    req,
-    _res,
-    next,
-    _end,
-  ) => {
+  const hitTracker: Record<string, JsonRpcRequest[]> = {};
+  const middleware: JsonRpcMiddleware<JsonRpcParams, Json> &
+    CreateHitTrackerMiddleware = (req, _res, next, _end) => {
     // mark hit for method
     const hitsForMethod = hitTracker[req.method] || [];
     hitsForMethod.push(req);