Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: replace ganache-core v2 with ganache-cli v6 #99

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 2, 2023

No description provided.

@socket-security
Copy link

socket-security bot commented Sep 2, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ganache-cli 6.12.2 filesystem, shell, environment +1 45.4 MB truffle-cicd

🚮 Removed packages: [email protected]

@socket-security
Copy link

socket-security bot commented Sep 2, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat changed the title devDeps: replache ganache-core v2 with ganache v7 @legobeat devDeps: replache ganache-core v2 with ganache v7 Sep 2, 2023
@legobeat legobeat force-pushed the devdeps-ganache-7 branch 4 times, most recently from f6e6968 to 2a764d7 Compare September 25, 2023 07:03
@legobeat legobeat changed the title devDeps: replache ganache-core v2 with ganache v7 devDeps: replache ganache-core v2 with ganache-cli v6 Nov 20, 2023
@legobeat legobeat marked this pull request as ready for review November 20, 2023 23:11
@legobeat legobeat requested a review from a team as a code owner November 20, 2023 23:11
@legobeat legobeat changed the title devDeps: replache ganache-core v2 with ganache-cli v6 devDeps: replace ganache-core v2 with ganache-cli v6 Nov 20, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are you planning to bump to Ganache 7 in a future PR to get rid of the ethereumjs-util dependency?

@legobeat
Copy link
Contributor Author

Looks good. Are you planning to bump to Ganache 7 in a future PR to get rid of the ethereumjs-util dependency?

Possibly - it seems usage needs to be updated for it, though.

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

ganache-cli legacy bin script confusion

@legobeat legobeat merged commit 2c495fd into MetaMask:main Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants