fix: Add useSafeChainsListValidation and useMultiRpcMigration to PreferencesController #4732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certainly! Here's the PR description in markdown format:
Explanation
Current state:
The
PreferencesController
does not include support for two new features related to network validation and multi-RPC migration behavior. Specifically, there is no existing functionality to:useSafeChainsListValidation
).useMultiRpcMigration
).Solution:
This PR adds two new properties to the
PreferencesController
state:useSafeChainsListValidation
: Allows enabling or disabling validation of networks against the safe chains list (chainid.network
).useMultiRpcMigration
: Controls whether the multi-RPC migration modal is displayed.Along with these additions, corresponding setter methods (
setUseSafeChainsListValidation
andsetUseMultiRpcMigration
) have been implemented. These methods allow for toggling the state of the new properties.Additional details:
true
to maintain expected functionality for users.There were no additional package updates or dependency changes required in this PR.
References
Changelog
@metamask/preferences-controller
useSafeChainsListValidation
property to thePreferencesController
state, allowing users to enable or disable safe chains list validation.useMultiRpcMigration
property to thePreferencesController
state, controlling the display of the multi-RPC migration modal.setUseSafeChainsListValidation
method to toggle theuseSafeChainsListValidation
property.setUseMultiRpcMigration
method to toggle theuseMultiRpcMigration
property.Checklist