Merge pull request #297 from informatics-lab/fix-nearcast-variables

Fix nearcast variables

forest/__init__.py

@@ -25,7 +25,7 @@
 .. automodule:: forest.presets
 
 """
-__version__ = '0.12.4'
+__version__ = '0.12.5'
 
 from .config import *
 from . import (

forest/nearcast.py

@@ -98,7 +98,7 @@ def variables(self, pattern):
         paths = self.locator.find(self.pattern)
         if len(paths) == 0:
             return []
-        return list(sorted(self._variables(paths[-1])))
+        return list(sorted(set(self._variables(paths[-1]))))
 
     @staticmethod
     def _variables(path):

test/test_drivers_nearcast.py

@@ -0,0 +1,28 @@
+import pytest
+import unittest.mock
+import pygrib
+from forest import nearcast
+
+
+def make_open(names):
+    # Simulate pygrib.open(path).select() -> messages
+    def _open(path):
+        messages = unittest.mock.Mock()
+        messages.select.return_value = [
+            {"name": name} for name in names
+        ]
+        return messages
+    return _open
+
+
+@pytest.mark.parametrize("names,expect", [
+    (["A", "A", "A"], ["A"]),
+    (["D", "C", "B", "A"], ["A", "B", "C", "D"]),
+])
+def test_navigator_variables(monkeypatch, names, expect):
+    pattern = ""
+    navigator = nearcast.Navigator(pattern)
+    navigator.locator = unittest.mock.Mock()
+    navigator.locator.find.return_value = ["some.grib"]
+    monkeypatch.setattr(pygrib, "open", make_open(names))
+    assert navigator.variables(pattern) == expect