Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General small plot improvements and website organisation #801

Merged
merged 16 commits into from
Aug 20, 2024

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Aug 19, 2024

  1. Add watermark with min/mean/max to plot - currently not user configurable to keep GUI simple.
  2. Increase number of contour levels to 20 from 10, to see more granularity in variables.
  3. Improve categorisation of recipes, as "Quick Looks" becomes quickly difficult to navigate through with large workflows.
  4. Relax restriction of ylim on histogram plots (previously 0 to 1), which made some plots illegible if x values are large (like pressure) as it is a normalised PDF where the area under the curve is equal to 1.
  5. Additional variables in default colorbar json and some tweaks to defaults. Recognise users will want different ranges depending on regions/seasons, but hopefully changes to defaults/additions here a useful starting point.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Coverage

@jwarner8 jwarner8 marked this pull request as ready for review August 19, 2024 13:20
@jwarner8 jwarner8 self-assigned this Aug 19, 2024
@jwarner8 jwarner8 added the enhancement New feature or request label Aug 19, 2024
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really nice additions. Left a couple small comments, so just ping me for re-review after they are addressed. This is mostly to remind me to port the changes over to the pcolormesh plots.

cset-workflow/extra-meta/colorbar_dict_alphabetical.json Outdated Show resolved Hide resolved
cset-workflow/extra-meta/colorbar_dict_alphabetical.json Outdated Show resolved Hide resolved
cset-workflow/extra-meta/colorbar_dict_alphabetical.json Outdated Show resolved Hide resolved
src/CSET/operators/plot.py Outdated Show resolved Hide resolved
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just use the script to sort the colour bar file, then merge.

src/CSET/operators/plot.py Outdated Show resolved Hide resolved
It now sorts recursively, and the file to be sorted is specifed on
the command line.
@jfrost-mo jfrost-mo merged commit 160317c into main Aug 20, 2024
1 check passed
@jfrost-mo jfrost-mo deleted the spatial_plot_watermark branch August 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants