Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pcolormesh plotting operator #787

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Add pcolormesh plotting operator #787

merged 5 commits into from
Aug 22, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Aug 12, 2024 •
edited
Loading

It is significantly faster than contourf, and gives a better idea of resolution.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

GitHub Copilot was used in this PR.

@jfrost-mo jfrost-mo mentioned this pull request Aug 12, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

Coverage

@jfrost-mo jfrost-mo self-assigned this Aug 12, 2024
@jfrost-mo jfrost-mo force-pushed the add_pcolormesh_plot branch 3 times, most recently from db56723 to 7456443 Compare August 15, 2024 09:18
@jfrost-mo jfrost-mo marked this pull request as ready for review August 15, 2024 09:21
@jfrost-mo jfrost-mo added the enhancement New feature or request label Aug 15, 2024
@jfrost-mo jfrost-mo force-pushed the add_pcolormesh_plot branch 2 times, most recently from 08e2cef to 2a41c17 Compare August 15, 2024 16:16
jwarner8
jwarner8 reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered given the only difference between these new functions and existing contourf is the iris method, whether existing functions could just be passed 'contourf' or 'pcolormesh' as an argument? Saves duplication of very similar functions

src/CSET/operators/plot.py Outdated Show resolved Hide resolved
@jfrost-mo jfrost-mo marked this pull request as draft August 22, 2024 09:13
@jfrost-mo jfrost-mo marked this pull request as ready for review August 22, 2024 09:26
jwarner8
jwarner8 reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see code refactored, minor comment regarding method name

src/CSET/operators/plot.py Show resolved Hide resolved
tests/operators/test_plots.py Show resolved Hide resolved
tests/operators/test_transect.py Show resolved Hide resolved
@jfrost-mo jfrost-mo merged commit 269ce93 into main Aug 22, 2024
7 checks passed
@jfrost-mo jfrost-mo deleted the add_pcolormesh_plot branch August 22, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwarner8 jwarner8 jwarner8 approved these changes

Assignees

@jfrost-mo jfrost-mo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfrost-mo @jwarner8