feat: Switch to mysqlclient from pymysql #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianswms
force-pushed
the
mysqlclient
branch
from
f28c5c0
to
03219cd
Compare
visch
requested changes
Aug 16, 2023
tests/test_core.py
Outdated
| @@ -158,13 +158,13 @@ def test_temporal_datatypes(): | |||
| metadata_obj.create_all(conn) | |||
| insert = table.insert().values( | |||
| column_date="2022-03-19", | |||
| column_time="06:04:19.222", | |||
There was a problem hiding this comment.
We do want to keep the time here as we've had issues with this before. Is there a reason this was changed?
There was a problem hiding this comment.
MySQL TIME datatype doesn't support fractional seconds by default, so I removed the fractional component. I've changed the test to use TIME(timezone=False, fsp=6) so that fractional seconds can be tested for.
tests/test_core.py
Outdated
| @@ -196,7 +196,7 @@ def test_temporal_datatypes(): | |||
| ) | |||
| assert test_runner.records[altered_table_name][0] == { | |||
| "column_date": "2022-03-19", | |||
| "column_time": "06:04:19.222000", | |||
Lint with ruff, black, isort, flake8
visch
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the mysqlclient library instead of pymysql.
Fix all failing tests and run linting checks.