Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop support for Python 3.8 #21

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,20 @@ permissions:
jobs:
build:
strategy:
fail-fast: false
matrix:
py_version: ["3.8", "3.9", "3.10"]
py_version: ["3.9", "3.10", "3.11"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup Python ${{ matrix.py_version }}
uses: actions/setup-python@v3
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.py_version }}
- name: Install Tap Airbyte Wrapper
run: |
python -m pip install --upgrade pip poetry
poetry env use ${{ matrix.py_version }}
poetry install
- name: Run SDK Tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion meltano.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins:
config:
airbyte_spec:
image: "airbyte/source-pokeapi"
tag: "0.1.5"
tag: "0.2.14"
airbyte_config:
pokemon_name: smeargle
loaders:
Expand Down
2 changes: 1 addition & 1 deletion mypy.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[mypy]
python_version = 3.9
python_version = 3.10
warn_unused_configs = True

[mypy-backoff.*]
Expand Down
573 changes: 106 additions & 467 deletions poetry.lock

Large diffs are not rendered by default.

43 changes: 25 additions & 18 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,27 +1,34 @@
[tool.poetry]
name = "tap-airbyte"
version = "0.6.0"
description = "`tap-airbyte` is a Singer tap for Airbyte, built with the Meltano Singer SDK."
version = "0.7.0"
description = "Singer tap for Airbyte, built with the Meltano Singer SDK."
readme = "README.md"
authors = ["Alex Butler"]
keywords = ["ELT", "Airbyte"]
license = "Apache 2.0"
keywords = [
"ELT",
"Airbyte",
]
classifiers = [
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]
license = "Apache-2.0"

[tool.poetry.dependencies]
python = "<3.12,>=3.8" # airbyte cdk is broken on 3.11 due to mutable defaults in dataclasses, go figure
requests = "^2.25.1"
singer-sdk = { version = "^0.36.0" }
fs-s3fs = { version = "^1.1.1", optional = true }
orjson = "^3.8.3"
python = ">=3.9,<3.12"
importlib-resources = { version = "==6.4.*", python = "<3.9" }
singer-sdk = { version="~=0.36.0", extras = [] }
fs-s3fs = { version = "~=1.1.1", optional = true }
orjson = "^3.10.6"

[tool.poetry.dev-dependencies]
pytest = "^6.2.5"
tox = "^3.24.4"
flake8 = "^3.9.2"
black = ">=21"
pydocstyle = "^6.1.1"
mypy = "^0.910"
types-requests = "^2.26.1"
isort = "^5.10.1"
[tool.poetry.group.dev.dependencies]
pytest = ">=8"
singer-sdk = { version="~=0.36.0", extras = ["testing"] }

[tool.poetry.extras]
s3 = ["fs-s3fs"]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_standard_tap_tests():
tests = get_standard_tap_tests(
TapAirbyte,
config={
"airbyte_spec": {"image": "airbyte/source-pokeapi", "tag": "0.1.5"},
"airbyte_spec": {"image": "airbyte/source-pokeapi", "tag": "0.2.14"},
"airbyte_config": {
"pokemon_name": "infernape",
},
Expand Down
17 changes: 10 additions & 7 deletions tests/test_syncs.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_weather_sync():

tap = TapAirbyte(
config={
"airbyte_spec": {"image": "airbyte/source-file", "tag": "0.2.32"},
"airbyte_spec": {"image": "airbyte/source-file", "tag": "0.5.8"},
"airbyte_config": {
"dataset_name": "test",
"format": "csv",
Expand Down Expand Up @@ -74,18 +74,19 @@ def test_weather_sync():
pass


def test_poke_sync():
def test_poke_sync_docker():
"""Run a sync and compare the output to a fixture derived from a public dataset.
This test provides a very strong guarantee that the tap is working as expected."""

tap = TapAirbyte(
config={
"airbyte_spec": {"image": "airbyte/source-pokeapi", "tag": "0.2.0"},
"airbyte_config": {
# sketch -> spore, endeavor, extreme speed, destiny bond w/ focus sash
# sketch -> spore, shell smash, baton pass, focus sash
# if you know, you know.
"pokemon_name": "smeargle",
},
"skip_native_check": True,
},
)

Expand Down Expand Up @@ -124,7 +125,8 @@ def test_poke_sync():
pass


def test_pub_apis_sync():
# TODO: Re-enable this?
def _test_pub_apis_sync():
"""Run a sync and compare the output to a fixture derived from a public dataset.
This test provides a very strong guarantee that the tap is working as expected."""

Expand Down Expand Up @@ -176,7 +178,7 @@ def test_docker_mount_sync():
data = Path(__file__).parent.joinpath("fixtures", "KPHX.csv")
tap = TapAirbyte(
config={
"airbyte_spec": {"image": "airbyte/source-file", "tag": "0.2.32"},
"airbyte_spec": {"image": "airbyte/source-file", "tag": "0.5.8"},
"airbyte_config": {
"dataset_name": "test",
"format": "csv",
Expand All @@ -185,6 +187,7 @@ def test_docker_mount_sync():
"storage": "local",
},
},
"skip_native_check": True,
"docker_mounts": [
{
"source": str(data.parent),
Expand Down Expand Up @@ -232,6 +235,6 @@ def test_docker_mount_sync():

if __name__ == "__main__":
test_weather_sync()
test_poke_sync()
test_pub_apis_sync()
test_poke_sync_docker()
_test_pub_apis_sync()
test_docker_mount_sync()
Loading