fix: Use airbyte state message format + tracking. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will fix incremental extraction for a few TAPs, like tap-amplitude and tap-s3. - Adds a new entry to state tracking json, 'airbyte_state'. - This new entry is populated on any invocation, and contains airbyte's way to track state as documented here: https://docs.airbyte.com/understanding-airbyte/database-data-catalog. - If this entry does not exist, we fallback to what was originally being done. - If this entry does exist, we use this data as the input state.json to airbyte's docker container.
|
@z3z1ma let me know if you have any questions on this PR |
|
@edgarrmondragon could you help getting the right pair of eyes on this? |
There was a problem hiding this comment.
I wonder if @SpaceCondor is affected by this or that this change at least doesn't break things for him
Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
edgarrmondragon
approved these changes
Sep 6, 2024
|
@JichaoS @arianeschang In the interesting of unblocking y'all I'm gonna merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will fix incremental extraction for a few TAPs, like tap-amplitude and tap-s3.