add ufm rust client #119
Open
add ufm rust client #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@kedeme @lennybe @haithamwj any comment on this PR? |
|
What about CI? at least build step, static code analysis. |
lennybe
reviewed
Sep 7, 2023
| #### *Version* | ||
| ``` | ||
| ./ufmcli version | ||
| 6.11.1-2 |
There was a problem hiding this comment.
Why do we need hardcoded UFM version here?
can we support regex or $UFM_VERSION > 6.11.1-2 != 6.12.1-5 e.t.c.?
| ``` | ||
| #### *Create a Partition Key* | ||
| ``` | ||
| ./ufmcli create --pkey 5 --mtu 2 --membership full --service-level 0 --rate-limit 2.5 --guids 0011223344560200 --guids 1070fd0300176625 --guids 0011223344560201 |
There was a problem hiding this comment.
can GUIDs be part of external configuration file and not hardcoded ?
| @@ -0,0 +1,55 @@ | |||
| /* | |||
| * Copyright © 2013-2022 NVIDIA CORPORATION & AFFILIATES. ALL RIGHTS RESERVED. | |||
| @@ -0,0 +1,20 @@ | |||
| /* | |||
| * Copyright © 2013-2022 NVIDIA CORPORATION & AFFILIATES. ALL RIGHTS RESERVED. | |||
| [package] | ||
| name = "ufmclient" | ||
| version = "0.1.2" | ||
| edition = "2021" |
There was a problem hiding this comment.
why are we using that old edition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UFM rust client includes a CLI and library written in
rust. Currently, it supports part of UFM operations. We will add new features on demand.