fix: Skip MAX_ACC_OUT_READ on the broken FW versions #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
approved these changes
Oct 29, 2024
Pull Request Test Coverage Report for Build 11628576864Details
💛 - Coveralls |
almaslennikov
force-pushed
the
max-acc-out-read
branch
from
05d9490
to
0356020
Compare
adrianchiris
approved these changes
Oct 30, 2024
ykulazhenkov
approved these changes
Oct 30, 2024
almaslennikov
force-pushed
the
max-acc-out-read
branch
2 times, most recently
from
f60c301
to
c3062d1
Compare
almaslennikov
changed the title
almaslennikov
force-pushed
the
max-acc-out-read
branch
from
c3062d1
to
579080d
Compare
almaslennikov
changed the title
According to the PRM, setting MAX_ACC_OUT_READ to zero enables the auto mode, which applies the best suitable optimizations. However, there is a bug in certain FW versions, where the zero value is not available. In this case, until the fix is available, skipping this parameter and emitting a warning Signed-off-by: Alexander Maslennikov <[email protected]>
almaslennikov
force-pushed
the
max-acc-out-read
branch
from
579080d
to
a9153f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the PRM, setting MAX_ACC_OUT_READ to zero enables the auto mode,
which applies the best suitable optimizations.
However, there is a bug in certain FW versions, where the zero value is not available.
In this case, until the fix is available, skipping this parameter and emitting a warning