[CI]: fixing false positives in the Secrets Scanner on doca_xlio_vNext branch #237
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vialogi
changed the title
|
bot:retest |
vialogi
force-pushed
the
HPCINFRA-2572_secrets_scanner_on_doca_xlio_vNext
branch
2 times, most recently
from
4dffe69
to
b2edb4d
Compare
We need to rename Jenkins secrets IDs to human readable form. Jenkins secrets we reference in the CI are currently represented in UUID format. It confuses Secrets Scanner, which takes these data for passwords. Renaming these secret IDs in Jenkins will allow us to restor Secrets Scanner normal workflow. issue: HPCINFRA-2572 Signed-off-by: Viacheslav Login <[email protected]>
vialogi
force-pushed
the
HPCINFRA-2572_secrets_scanner_on_doca_xlio_vNext
branch
from
b2edb4d
to
13031f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We update references to Jenkins's secrets
What
We update CI with updated Jenkins secrets references
Why ?
Secrets Scanner does not work correctly with the old secrets format
Change type
What kind of change does this PR introduce?
Check list