issue: 3782717 Improve Fairness for NGINX High Concurrency #224
+135
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasis
added
documentation
AlexanderGrissik
approved these changes
Sep 11, 2024
Some lines are unreasonably long in README. This can complicate reading in a small terminal window. In cases where formatting doesn't matter, limit the lines similarly to surrounding text (either 80 or 100 symbols). README doesn't have strict convention, so keep it just tidy for now. Signed-off-by: Dmytro Podgornyi <[email protected]>
Keep consistent logs format. Signed-off-by: Dmytro Podgornyi <[email protected]>
The option affects both xlio_stats and XLIO_STATS_FILE now and only xlio_stats is limited by a hardcoded upper limit. Signed-off-by: Dmytro Podgornyi <[email protected]>
Reduce in_protocol_t size from default 4-byte enum to uint16_t. in_protocol_t represents several values and doesn't have to be 4 bytes in size. Reducing it to 2 bytes allows to utilize flow_tuple layout more efficiently. This also reduces sockinfo and use_family_rule size. Signed-off-by: Dmytro Podgornyi <[email protected]>
XLIO has a feature to create files with the process PID in the name. For example, /tmp/xlio-%d.txt. However, the stats file is created once in the library constructor and shared between all the child processes. Re-open the stats file in the child processes in case of a per-process file name. This allows to save stats for each process in a separate file and avoid content corruption due to concurrent writes. Signed-off-by: Dmytro Podgornyi <[email protected]>
Signed-off-by: Dmytro Podgornyi <[email protected]>
There are scenarios when we want to skip TX polling in the TX path. For example, XLIO Socket API aims to trigger all/most of the events in the polling context. TX polling in the TX path can lead to a completion event from a flush context. Avoid TX polling in the TX path if the flag XLIO_TX_SKIP_POLL is set. Signed-off-by: Dmytro Podgornyi <[email protected]>
XLIO Socket API doesn't use epoll and epfd per socket. Therefore, such an epfd is a waste of an open fd per socket. Linux kernel has hardcoded limit of 1M open fds per process. Close the epfd once we know that the socket is an extra API socket, so we can raise the upper sockets limit from 500K to 1M per process. Future direction is to avoid extra epfd open/close actions per socket. Signed-off-by: Dmytro Podgornyi <[email protected]>
This call allows to change the callbacks in runtime. It must be serialized with the group and the sockets activities. Signed-off-by: Dmytro Podgornyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is set of commit from the fairness activity. They're quality improvements that help in multi process statistics analysis and running XLIO on the client side on a big scale.
What
Quality improvements.
Why ?
Improvements and benchmark scenarios analysis.
Change type
What kind of change does this PR introduce?
Check list