Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect pilot info box drawing #1627

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Fix incorrect pilot info box drawing #1627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions megameklab/src/megameklab/printing/PrintRecordSheet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,9 @@ private void shadeTableRows() {

private void makeFrameless() {
for (Element e : getElementsByClass(FRAME)) {
hideElement(e.getAttributes().getNamedItem("id").getNodeValue(), options.isFrameless());
if (options.isFrameless()) {
hideElement(e.getAttributes().getNamedItem("id").getNodeValue());

// I have no idea with this loop is necessary
// Hiding a parent should hide its children
// But without it pilot data sneaks onto the sheet
Expand All @@ -281,7 +282,7 @@ private void makeFrameless() {
if (child.getId() == null) {
child.setId(UUID.randomUUID().toString());
}
hideElement(child.getId(), true);
hideElement(child.getId());
}
}
}
Expand Down