HEVC: add missing parsing of some multilayer SPS elements #2092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few multiview samples generated by either iPhone or Apple's authoring tools, and for all of them i get the following:
In both cases, the offset reported is the start of whatever box follows the lhvC one, so it was clear there were LHEVCDecoderConfigurationRecord parsing related issues.
Looking into it i found one problem parsing SPS when nuh_layer_id > 0 and one when MultiLayerExtSpsFlag is true (nuh_layer_id > 0 && sps_ext_or_max_sub_layers_minus1 == 7), both of which i'm fixing in this PR, as the LHEVCDecoderConfigurationRecord itself seems to be ok.
Only the latter is enough to fix parsing the samples i have, but i'm including the other as well to ensure correct parsing for all files. You can check the syntax i'm fixing in section F.7.3.2.2.1 of ITU-T H.265