Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Improvements 2 #2084

Merged
merged 1 commit into from
Jun 29, 2024
Merged

HTML Improvements 2 #2084

merged 1 commit into from
Jun 29, 2024

Conversation

cjee21
Copy link
Contributor

@cjee21 cjee21 commented Jun 26, 2024

More HTML improvements:

  • Enable native dark mode
    • There is now dark mode for the exported HTML on all modern browsers
    • Will work in MediaInfo GUI too with newer browser engine implemented
  • Move all styles from inline to <style> tag
  • Remove colspans that appear to do nothing and cause validator errors
  • Standardize indents

HTML validator results:
Screenshot 2024-06-28 at 17-01-08 Showing results for uploaded file Test mp4 MediaInfo html - Nu Html Checker

There is only one warning for language.

Tested for proper display and dark mode switching on Edge, Firefox and MediaInfo VCL GUI.

This change makes MediaInfo Qt GUI display differently since it is currently not using a web engine for the HTML view. This should be fixable on Qt GUI side if necessary.

@JeromeMartinez
Copy link
Member

Thank you. For this PR and the MediaInfo ones related to HTML, we'll check them and merge them after the release (expected this week), in order not to change so much code at the last minute.

@cjee21
Copy link
Contributor Author

cjee21 commented Jun 28, 2024

Turns out there's a CSS syntax mistake after all. I'll correct that and update first post. Been some time since I last used @media (prefers-color-scheme: dark) and the example that I referred to turned out to be non-ideal.

Improve and modernise the HTML that is generated.
@cjee21
Copy link
Contributor Author

cjee21 commented Jun 29, 2024

Some more improvements:

  • improved column sizing to hopefully prevent any chances of text being clipped
  • replaced <i> and <br> with CSS
  • further improved indents of generated HTML code

Tested on Edge, Firefox and MediaInfo VCL GUI (both HTML engines). HTML validator results remain the same.

@JeromeMartinez JeromeMartinez merged commit ccbcf53 into MediaArea:master Jun 29, 2024
9 checks passed
@cjee21 cjee21 deleted the html branch June 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants