MXF: Support of SMPTE ST 422-2019 I2 #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I2 mode is interlaced but with FrameLayout FULL_FRAME, despite what is for interlaced content for all other formats.
All the I2 files I received up to #2037 violates this part of the spec but well, we need to at least support correctly when theoretically a file is conforming to specs.
In order to not break the support of I2 files in the wild, both FrameLayout FULL_FRAME and FrameLayout SEPARATE_FIELDS are supported and there is a probe in the JP2k frame in case of former UL with essence container label Content Kind of 0.
Mainly fix #2037 but also fix some incoherent issues about frame rate with other files.