Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two patches for your review. #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikecancilla
Copy link

One mxf fix and one soft-telecine fix. Thanks, Mike

mikecancilla added 2 commits May 9, 2016 15:24
…ue ID, not just the first 4. DTS-HD files, for example, can contain the first 4 MXF unique ID bytes, which ends up as an MXF false positive.
…ut code is supposed to do, but it does nothing in its if() block. Commenting out this code allows the soft-telecine code to be executed.
@JeromeMartinez
Copy link
Member

I tested with my bunch of test files and I see the issues (I get some DTS-HD files with invalid MXF sync and I get some telecine streams detected)

There are several regressions with this PR.
MXF: File_Mxf::Synchronize() is used also for synchronization after a seek in the file, not only at the beginning. Additionally, MXF is also used in IMX (MPEG Video in MXF header in MOV, or Sony Acquisition Metadata in MXF in MXF)
Telecine: I don't remember exactly, maybe the idea was to avoid non telecine (when there is a change in the stream not telecine)

So I see that the PR shows several flaws in MediaInfo, but it is not acceptable as is. I'll test it more later this week and say how to have it accepted (issues fixed without creating new issues)

@JeromeMartinez JeromeMartinez self-assigned this May 10, 2016
@mikecancilla
Copy link
Author

Thanks for your feedback. Yes, I'm sure my fixes (like the MXF fix) possibly fail some other use cases, but for our use these two code changes cause no regressions and fix bugs.

Please keep me informed of the progress if possible. Is there a mailing list?

Mike

@JeromeMartinez
Copy link
Member

Is there a mailing list?

No.
But for issues, you can open a ticket.

Please keep me informed of the progress if possible.

This is the goal of Pull Requests, we can debate here of the outcome ;-).

@mikecancilla
Copy link
Author

If you'd like me to open a ticket I can do that. I'm not here to debate, just help. :-)

@JeromeMartinez
Copy link
Member

If you'd like me to open a ticket I can do that.

You asked for a mailing list. If it is only for this PR, no need to do something, we discuss here. Else (if it is not related to this PR), please open an issue ticket.

I'm not here to debate, just help. :-)

Debate in the meaning that I'll do a counterproposal and ask for feedback.
Don't hesitate to help more ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants