-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two patches for your review. #159
base: master
Are you sure you want to change the base?
Conversation
…ue ID, not just the first 4. DTS-HD files, for example, can contain the first 4 MXF unique ID bytes, which ends up as an MXF false positive.
…ut code is supposed to do, but it does nothing in its if() block. Commenting out this code allows the soft-telecine code to be executed.
I tested with my bunch of test files and I see the issues (I get some DTS-HD files with invalid MXF sync and I get some telecine streams detected) There are several regressions with this PR. So I see that the PR shows several flaws in MediaInfo, but it is not acceptable as is. I'll test it more later this week and say how to have it accepted (issues fixed without creating new issues) |
Thanks for your feedback. Yes, I'm sure my fixes (like the MXF fix) possibly fail some other use cases, but for our use these two code changes cause no regressions and fix bugs. Please keep me informed of the progress if possible. Is there a mailing list? Mike |
No.
This is the goal of Pull Requests, we can debate here of the outcome ;-). |
If you'd like me to open a ticket I can do that. I'm not here to debate, just help. :-) |
You asked for a mailing list. If it is only for this PR, no need to do something, we discuss here. Else (if it is not related to this PR), please open an issue ticket.
Debate in the meaning that I'll do a counterproposal and ask for feedback. |
One mxf fix and one soft-telecine fix. Thanks, Mike