Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix openssl timeout error message #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryantm
Copy link

@ryantm ryantm commented Oct 13, 2021

When I run this

$ openssl version
OpenSSL 1.1.1k  25 Mar 2021
$ openssl s_client -connect timeout.badssl.com:444
139666931979584:error:0200206E:system library:connect:Connection timed out:crypto/bio/b_sock2.c:110:
139666931979584:error:2008A067:BIO routines:BIO_connect:connect error:crypto/bio/b_sock2.c:111:
connect:errno=110

Note the error message does not contain a space. This removes the space so a proper error message can be displayed instead of

ERROR: The file named /var/tmp/cert.gjtbl2 is unreadable or doesn't exist
ERROR: Please check to make sure the certificate for redacted.com:443 is valid

When I run this
```
$ openssl version
OpenSSL 1.1.1k  25 Mar 2021
$ openssl s_client -connect timeout.badssl.com:444
139666931979584:error:0200206E:system library:connect:Connection timed out:crypto/bio/b_sock2.c:110:
139666931979584:error:2008A067:BIO routines:BIO_connect:connect error:crypto/bio/b_sock2.c:111:
connect:errno=110
```
Note the error message does not contain a space. This removes the space so a proper error message can be displayed instead of 

```
ERROR: The file named /var/tmp/cert.gjtbl2 is unreadable or doesn't exist
ERROR: Please check to make sure the certificate for redacted.com:443 is valid
```
@leahneukirchen
Copy link

leahneukirchen commented Oct 18, 2021

I suggest to use [ ]* to match the old and the new output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants