Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle duplicate density and parameter #264

Conversation

elmbeech
Copy link
Contributor

pull request for the staled pull request #250 and #232

this pull request keeps the changes to the existing code bases as small as possible.
default settings were chosen so that the current models not will break through these changes.
each case was manually tested, the code works as expected.

add_density and add_parameter functions:

  • Microenvironment::add_density: throw error, if a density with the same name already exists.
  • Parameters::add_parameter : throw error, if a parameter with the same name and type already exists.

update_density and update_parameter functions:

  • Microenvironment::update_density : new function which does not throw an error but updates the values, if a density with the same name already exists.
  • Parameters::update_parameter : new function which does not throw an error but updates the values, if a parameter with the same name and type already exists.

function calls arguments:

  • load_PhysiCell_config_file: additional bool update_variables argument with default set to false.
  • setup_microenvironment_from_XML (called from load_PhysiCell_config_file): additional bool update_density argument with default set to false.
  • User_Parameters::read_from_pugixml (called from load_PhysiCell_config_file): additional bool update_parameter argument with default set to false.

…s. additionally, update_density functions were implemented.
…xists. additionally, update_parameter functions were implemented and an update_variables argument with default setting false was added to the load_PhysiCell_config_file, parameters.read_from_pugixml, and setup_microenvironment_from_XML functions.
@elmbeech
Copy link
Contributor Author

superseded by pull request #298.
closed.

@elmbeech elmbeech closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant