Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Makefile jpeg and git functions work on Windows, Apple, and Linux. #209

Closed
wants to merge 3 commits into from

Conversation

elmbeech
Copy link
Contributor

@elmbeech elmbeech commented Feb 9, 2024

I used the UNAME_S variable and wrote ifeq else endif statements to make make jpeg and make gif work on Windows, Apple, and Linux.

@MathCancer
Copy link
Owner

Full requests are only accepted into the development branch. Never main/master.

GIF and JPEG have worked across platforms with properly installed ImageMagick, so I don't quite understand the purpose of this PR. In any event, PRs are never accepted to master except from development during a release.

@MathCancer MathCancer closed this Feb 10, 2024
@elmbeech
Copy link
Contributor Author

elmbeech commented Feb 11, 2024

i see my mistake. i will make a pull request to the development branch!

it is not true that gif anf jpeg has worked across platform!
please have a look at the linux setup guide page 4:
https://github.com/physicell-training/ws2023/blob/main/setup/PhysiCell_ws2023_Linux_setup.pdf
the problem is that all linux distributions still run image magick version 6 for deep rooting reasons.
but the magick command was only introduced in image magick version 7.
the are many linux user in the PhysiCell community, not only windows, apple m, and apple intel users. linux is one of the major platforms. we should support them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants