Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in reading in rules. #207

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix bug in reading in rules. #207

merged 2 commits into from
Jun 3, 2024

Commits on Jan 8, 2024

  1. Fix bug in reading in rules. 

    Just needed to initialize the pointers in a better way for them to be passed across functions and objects. I won't pretend to understand why this works, only that it does work.
    @drbergman
    drbergman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ebee16b View commit details
    Browse the repository at this point in the history

  2. Fixing the fix... 

    My initial fix unsynched the rules_map and the rules members of Hypothesis_Ruleset. This meant that when add_signal is called, only the Hypothesis_Rule's pointed to by the rules_map were updated and not the Hypothesis_Rule's in the rules vector.

In this fix, the rules vector is now a vector of pointers to Hypothesis_Rules. See Lines 780 and 781 where both end up with the same (pointer) value stored.
    @drbergman
    drbergman committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    cb15fb3 View commit details
    Browse the repository at this point in the history