Allow staring and unstarring repos within the repo details page #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingio
requested changes
Nov 6, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/repo/tab/RepoDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/repo/tab/RepoDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/repo/tab/RepoDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/repo/tab/RepoDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
Sculas
reviewed
Nov 6, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
commented
Nov 6, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Sculas <[email protected]> Co-authored-by: Wing <[email protected]>
X1nto
reviewed
Nov 7, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/screens/repo/tab/DetailsTab.kt
Outdated
Show resolved
Hide resolved
X1nto
reviewed
Nov 7, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt
Outdated
Show resolved
Hide resolved
wingio
requested changes
Nov 7, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/repo/tab/RepoDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt
Show resolved
Hide resolved
|
@wingio Can you clarify what the missing "color fading" is? |
|
lines 49, 57, and 65 in LargeSegmentedButton.kt need to have |
X1nto
reviewed
Nov 12, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/LargeSegmentedButton.kt
Outdated
Show resolved
Hide resolved
wingio
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
Todo
Review