Add account switcher #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushiiMachine
requested changes
Sep 5, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/screens/settings/AccountSettingsScreen.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/utils/ModifierUtils.kt
Outdated
Show resolved
Hide resolved
...c/commonMain/kotlin/com/materiiapps/gloom/ui/viewmodels/settings/AccountSettingsViewModel.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/widgets/accounts/AccountSwitcherSheet.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/widgets/accounts/AccountSwitcherSheet.kt
Outdated
Show resolved
Hide resolved
- Use remember for all account lists - Add keys to button items - Use items overload that accepts a list - Fix Modifier.thenIf utility - Run formatter
rushiiMachine
requested changes
Sep 5, 2023
app/src/main/java/com/materiiapps/gloom/ui/viewmodels/main/MainViewModel.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/screens/auth/LandingScreen.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/screens/settings/AccountSettingsScreen.kt
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/screens/settings/AccountSettingsScreen.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/widgets/accounts/AccountSwitcherSheet.kt
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/widgets/accounts/AccountSwitcherSheet.kt
Outdated
Show resolved
Hide resolved
rushiiMachine
approved these changes
Sep 5, 2023
zt64
suggested changes
Sep 6, 2023
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/settings/SettingsButton.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/navbar/LongClickableNavBarItem.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/navbar/LongClickableNavBarItem.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/navbar/LongClickableNavBarItem.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/bottomsheet/BottomSheetScope.kt
Show resolved
Hide resolved
app/src/main/java/com/materiiapps/gloom/ui/viewmodels/main/MainViewModel.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/widgets/accounts/AccountItem.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/components/bottomsheet/BottomSheet.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/screens/auth/LandingScreen.kt
Outdated
Show resolved
Hide resolved
ui/src/commonMain/kotlin/com/materiiapps/gloom/ui/screens/auth/LandingScreen.kt
Outdated
Show resolved
Hide resolved
zt64
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently does not support enterprise accounts (I have no way to test them)