fix

Martinsos · Sep 4, 2024 · 273ac30 · 273ac30
1 parent 19bc5be
commit 273ac30
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -117,6 +117,8 @@ jobs:
       - name: Build wheels
         run: |
           if [ ${{ matrix.os }} == "macos-13" ]; then
+            # Default is x86-64 only, but this way we also build universal2 wheels,
+            # which work on both intel (x86-64) and apple silicon (arm64).
             export CIBW_ARCHS_MACOS="x86-64 universal2"
           fi
           make wheels

diff --git a/bindings/python/Makefile b/bindings/python/Makefile
@@ -68,7 +68,7 @@ sdist: ${BUILD_FILES} MANIFEST.in
 # running `make sdist` in the containers at the start of every wheel build.
 wheels: clean edlib
 	python -m pip install cibuildwheel==2.20.0
-	CIBW_SKIP="pp* *-manylinux_i686 cp38-*" \
+	CIBW_SKIP="pp* *-manylinux_i686" \
 	CIBW_BEFORE_BUILD="make sdist" \
 	CIBW_TEST_COMMAND="python3 {project}/test.py" \
 	python -m cibuildwheel --output-dir wheelhouse