Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max length from group_name #6668

Merged

Conversation

pretendWhale
Copy link
Contributor

@pretendWhale pretendWhale commented Jul 13, 2023

Motivation and Context

Remove constraint on maximum length of group_name, to resolve issues with long group names (particularly for scanned exams).

Your Changes

Description:
Increase limit on group name to 100 characters, both in the database and the model validations

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested in the web interface with scanned exams, ran and updated the model tests.

Questions and Comments (if applicable)

Two points:

  • The database migration is not reversible. We could implement a down method, but I wasn't sure how to handle groups with names > 30 characters.
  • This PR does not add a limit to repository name length. This could be added.

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

Pull request to make documentation changes (if applicable)

@pretendWhale pretendWhale changed the title increase maximum group name length to 100 Increase maximum group name length to 100 Jul 13, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 13, 2023

Pull Request Test Coverage Report for Build 5580058980

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.69%

Totals Coverage Status
Change from base Build 5548616008: 0.0%
Covered Lines: 37109
Relevant Lines: 39937

💛 - Coveralls

Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pretendWhale great research, the "path length" argument we were discussing really applies to repo name, not group name. Given this, let's just drop the group_name length validation altogether.

@pretendWhale pretendWhale changed the title Increase maximum group name length to 100 Remove max length from group_name Jul 14, 2023
Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pretendWhale oh please also add a Changelog entry.

@david-yz-liu david-yz-liu merged commit 16e5aa6 into MarkUsProject:master Jul 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants