-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove max length from group_name #6668
Remove max length from group_name #6668
Conversation
Pull Request Test Coverage Report for Build 5580058980
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pretendWhale great research, the "path length" argument we were discussing really applies to repo name, not group name. Given this, let's just drop the group_name
length validation altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pretendWhale oh please also add a Changelog entry.
Motivation and Context
Remove constraint on maximum length of
group_name
, to resolve issues with long group names (particularly for scanned exams).Your Changes
Description:
Increase limit on group name to 100 characters, both in the database and the model validations
Type of change (select all that apply):
Testing
Tested in the web interface with scanned exams, ran and updated the model tests.
Questions and Comments (if applicable)
Two points:
down
method, but I wasn't sure how to handle groups with names > 30 characters.Checklist
Pull request to make documentation changes (if applicable)