Tests: increase flaky test coverage for course model (#6667)

MarkUsProject · Jul 10, 2023 · b9311ba · b9311ba
1 parent dccb59b
commit b9311ba
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/spec/models/course_spec.rb b/spec/models/course_spec.rb
@@ -567,11 +567,8 @@
 
         student1_data = "#{user1.user_name},#{user1.last_name},#{user1.first_name},,,#{user1.email}\n"
         student2_data = "#{user2.user_name},#{user2.last_name},#{user2.first_name},,,#{user2.email}\n"
-        if user1.user_name <= user2.user_name
-          expected = student1_data + student2_data
-        else
-          expected = student2_data + student1_data
-        end
+        student_data = [student1_data, student2_data]
+        expected = student_data.sort.join
         expect(result).to eq(expected)
       end
     end
@@ -607,7 +604,6 @@
       let!(:student2) { create :student, user: user2, course: course }
       it 'returns the data of the students' do
         result = course.export_student_data_yml
-        expected = []
 
         student1_data = {
           user_name: user1.user_name,
@@ -626,14 +622,7 @@
           id_number: nil,
           section_name: nil
         }
-
-        if user1.user_name <= user2.user_name
-          expected.push(student1_data)
-          expected.push(student2_data)
-        else
-          expected.push(student2_data)
-          expected.push(student1_data)
-        end
+        expected = [student1_data, student2_data].sort_by { |a| a[:user_name] }
         expect(result).to eq(expected.to_yaml)
       end
     end