fix(retain-old-grading-data-option): fixed inconsistent override chec…

…kbox behaviour
MarkUsProject · Oct 14, 2024 · 1605f0a · 1605f0a
1 parent 2346280
commit 1605f0a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/app/assets/javascripts/Components/Modals/collect_submissions_modal.jsx b/app/assets/javascripts/Components/Modals/collect_submissions_modal.jsx
@@ -27,7 +27,7 @@ class CollectSubmissionsModal extends React.Component {
       this.state.collect_time === "collect_current",
       // Always apply late penalty when collecting based on due date
       this.state.apply_late_penalty || this.state.collect_time === "collect_due_date",
-      this.state.retain_existing_grading
+      this.state.override && this.state.retain_existing_grading
     );
   };
 
@@ -102,7 +102,12 @@ class CollectSubmissionsModal extends React.Component {
               <legend>{I18n.t("submissions.collect.collection_options")}</legend>
               <p>
                 <label>
-                  <input type="checkbox" name="override" onChange={this.handleOverrideChange} />
+                  <input
+                    type="checkbox"
+                    defaultChecked={this.state.override}
+                    name="override"
+                    onChange={this.handleOverrideChange}
+                  />
                   &nbsp;
                   <span>{I18n.t("submissions.collect.override_existing")}</span>
                 </label>