Commits on Aug 28, 2024

1. macos: fix gu_cond usage for darwin after 09848b6 …

   the patch 09848b6 by Jan from 2021-11-11 14:22:24 +0200 that swapped the
   order of the arguments to gu_mutex_init_SYS. so now its
   `gu_mutex_init_SYS(const wsrep_mutex_key_t* key, gu_mutex_t_SYS *mutex)`
   so that for keyless mutexes its using (NULL, &mutex).
   
   considering GU_BARRIER_THREAD_SYS replacement:
   
   it was introduced by dabe053 8 years ago, but I suppose it never
   compiled as at that moment there were no GU_BARRIER_THREAD_SYS.
   
   it is synonymous to PTHREAD_BARRIER_SERIAL_THREAD that is must return
   something non-usual on success (here its -1) for a thread synced with a
   barrier as per POSIX https://linux.die.net/man/3/pthread_barrier_wait
   
   > The constant PTHREAD_BARRIER_SERIAL_THREAD is defined in
   <[pthread.h](https://linux.die.net/include/pthread.h)> and its value
   shall be distinct from any other value returned by
   pthread_barrier_wait().
   
   > Upon successful completion, the pthread_barrier_wait() function shall
   return PTHREAD_BARRIER_SERIAL_THREAD for a single (arbitrary) thread
   synchronized at the barrier and zero for each of the other threads.
   
   there is no such a constant in the code GU_BARRIER_THREAD_SYS.
   
   Signed-off-by: Ivan Prisyazhnyy <[email protected]>

   

   sitano committed Aug 28, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6bed224
   • Browse repository at this point

   Copy the full SHA

   6bed224 View commit details

   Browse the repository at this point in the history