Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-factor factories for asan and ubsan #406

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Re-factor factories for asan and ubsan #406

wants to merge 1 commit into from

Conversation

vladbogo
Copy link
Collaborator

@vladbogo vladbogo commented Apr 9, 2024

No description provided.

fauust
fauust reviewed Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@fauust fauust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but CI is failing.

common_factories.py Outdated Show resolved Hide resolved
common_factories.py Outdated Show resolved Hide resolved
common_factories.py Outdated Show resolved Hide resolved
@vladbogo vladbogo force-pushed the refactor branch 6 times, most recently from 2585f26 to cf57188 Compare April 9, 2024 13:25
@vladbogo vladbogo requested a review from fauust April 9, 2024 13:29
grooverdan
grooverdan reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@grooverdan grooverdan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really like the concept. See how it looks after merge conflicts resolve.

Looks like this will make changing freebsd to clang easy too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grooverdan grooverdan grooverdan left review comments

@fauust fauust fauust approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladbogo @grooverdan @fauust