Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #44

Merged
merged 13 commits into from
May 17, 2024
Merged

Fix tests #44

merged 13 commits into from
May 17, 2024

Conversation

jalew188
Copy link
Collaborator

@jalew188 jalew188 commented May 16, 2024

AlphaRaw now supports testing directly for .raw/.wiff files on Windows/Linux/MacOS-intel64 based on pythonnet:

  1. conda install mono (Installing mono for MacOS-arm64 is a bit complicated, see https://github.com/MannLabs/alpharaw?tab=readme-ov-file#installation).
  2. pip install alpharaw including pythonnet. This must be done after mono installation.
  3. Run tests (cd tests then run . ./run_tests.sh).

Thus, almost all RAW data readers are tested.

@jalew188 jalew188 marked this pull request as draft May 16, 2024 18:47
@jalew188 jalew188 requested a review from mschwoer May 16, 2024 21:22
@jalew188 jalew188 marked this pull request as ready for review May 16, 2024 21:28
@jalew188 jalew188 requested a review from GeorgWa May 16, 2024 21:29
GeorgWa
GeorgWa previously approved these changes May 17, 2024
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/download_test_data.py Show resolved Hide resolved
mschwoer
mschwoer previously approved these changes May 17, 2024
Copy link

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! smart idea to leverage all current notebooks to immediately boost test coverage!

alpharaw/sciex.py Show resolved Hide resolved
tests/download_test_data.py Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@jalew188 jalew188 dismissed stale reviews from mschwoer and GeorgWa via 3cd44f2 May 17, 2024 12:08
@GeorgWa GeorgWa self-requested a review May 17, 2024 12:31
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GeorgWa GeorgWa merged commit 29bff4c into development May 17, 2024
6 checks passed
@GeorgWa GeorgWa deleted the fix_tests branch May 17, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants