Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out of bounds segfault #272

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Fix out of bounds segfault #272

merged 4 commits into from
Jul 15, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jul 12, 2024

This should capture out-of bounds based sefaults like #260

@GeorgWa GeorgWa requested a review from mschwoer July 12, 2024 10:08
@GeorgWa GeorgWa changed the base branch from main to development July 12, 2024 10:08
@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Jul 12, 2024
@GeorgWa GeorgWa marked this pull request as ready for review July 12, 2024 10:11
mschwoer
mschwoer approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@GeorgWa GeorgWa added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Jul 13, 2024
@GeorgWa GeorgWa linked an issue Jul 13, 2024 that may be closed by this pull request
Mono runtime error #260
Open
@GeorgWa GeorgWa changed the title Improved e2e Fix out of bounds segfault Jul 13, 2024
@GeorgWa GeorgWa added the bug Something isn't working label Jul 13, 2024
@GeorgWa GeorgWa requested a review from mschwoer July 13, 2024 11:27
mschwoer
mschwoer approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/plexscoring.py Show resolved Hide resolved
alphadia/features.py Show resolved Hide resolved
@GeorgWa GeorgWa merged commit 4399423 into development Jul 15, 2024
4 checks passed
@GeorgWa GeorgWa deleted the improved-e2e branch July 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mono runtime error
2 participants
@GeorgWa @mschwoer